-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-117026: fix wrong sentence in SimpleHTTPRequestHandler #117027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…xt files The code does not differentiate between text and binary files so the sentence should be removed from the doc. See python#117026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good. But something that confuses me is that it looks like the line of code in server.py has never changed, so it's not like this something that changed from python2 to python3.
This feels like Chesterson's fence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Thank you for your contribution @SalehDehqanpour.
|
Thanks @SalehDehqanpour for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <[email protected]>
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <[email protected]>
|
GH-134107 is a backport of this pull request to the 3.14 branch. |
|
GH-134108 is a backport of this pull request to the 3.13 branch. |
…r docs (GH-117027) (GH-134107) The code was changed in 0f7cddc (bpo-839496/gh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <[email protected]>
…r docs (GH-117027) (GH-134108) The code was changed in 0f7cddc (bpo-839496/gh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <[email protected]>
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
The code does not differentiate between text and binary files so the sentence should be removed from the doc. See #117026
📚 Documentation preview 📚: https://cpython-previews--117027.org.readthedocs.build/